NO-ISSUE: Refactoring test codes to use @EmbeddedKafka #3871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chickenchickenlove <[email protected]>
artembilan
requested changes
Apr 28, 2025
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
I don't this a reason to do this refactoring since having an embedded Kafka as a bean is totally valid scenario. Therefore we have to have some tests in the project to cover that behavior.
What I meant on your other PR that there is no reason to go extra mile if we can just use respective annotation.
Does that make sense?
Contributor
Author
|
@artembilan thanks for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some test codes create
KafkaBrokerby callingnew EmbeddedKafkaBroker(...).Using the
@EmbeddedKafkaannotation to create abrokercan help minimize the amount of code that needs to be modified when major updates(579ae6a), such as the changes to the broker implementation inSpring for Apache Kafka 4.0.0, occur.From this perspective, I believe that using
@EmbeddedKafkaoffers a slight improvement in terms of maintainability for test code.When you have time, Please take a look. 🙇♂️